| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Chris Dunlop <chris(at)onthe(dot)net(dot)au>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Australian timezone configure option |
| Date: | 2001-06-12 16:22:29 |
| Message-ID: | 8950.992362949@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Here is a new version of the patch.
It's still horridly ugly. Why not put the three Aussie-specific entries
in a separate aussie_datetktbl array, and have the lookup look like
if (Australian_timezones)
{
tp = datebsearch(lowtoken, aussie_datetktbl, sz_aussie_datetktbl);
if (tp == NULL)
tp = datebsearch(lowtoken, datetktbl, szdatetktbl);
}
else
tp = datebsearch(lowtoken, datetktbl, szdatetktbl);
instead of modifying the lookup table on the fly.
> I found I didn't need to clear the date cache.
Hmm, are you sure about that? I'm not.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2001-06-12 16:24:57 | Re: Patch to include PAM support... |
| Previous Message | Bruce Momjian | 2001-06-12 16:21:39 | Re: Re: [PATCHES] Australian timezone configure option |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2001-06-12 16:24:57 | Re: Patch to include PAM support... |
| Previous Message | Bruce Momjian | 2001-06-12 16:21:39 | Re: Re: [PATCHES] Australian timezone configure option |