| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table |
| Date: | 2019-01-07 04:49:49 |
| Message-ID: | 8875e674-8d94-9e0c-a773-9c55bbb4601e@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for reviewing.
On 2018/12/31 20:23, Peter Eisentraut wrote:
> On 06/12/2018 05:46, Amit Langote wrote:
>> /*
>> * We currently only support writing to regular tables.
>> */
>
> I think that comment should stay above the code you are adding.
Do you mean to keep it at the top and expand it to mention the point about
partitioned and foreign tables, like this:
/*
- * We currently only support writing to regular tables.
+ * We currently only support writing to regular tables. However, give
+ * a more specific error for partitioned and foreign tables.
*/
+ if (relkind == RELKIND_PARTITIONED_TABLE)
If so, that makes sense. I've updated the patch like that.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| partitioned-table-not-supported-error-logrep-v4.patch | text/plain | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2019-01-07 05:10:42 | Re: btree.sgml typo? |
| Previous Message | Michael Paquier | 2019-01-07 03:26:12 | Prevent extension creation in temporary schemas |