Re: pgsql: Rework the pg_statistic_ext catalog

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Rework the pg_statistic_ext catalog
Date: 2019-06-16 01:18:18
Message-ID: 8833.1560647898@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> writes:
> Rework the pg_statistic_ext catalog

So ... not one of the buildfarm members that are running TAP tests
likes this. The failures look like

# Running: pg_dump --no-sync --file=/Users/tgl/pgsql/src/bin/pg_dump/tmp_check/tmp_test_cSh8/role.sql --role=regress_dump_test_role --schema=dump_test_second_schema postgres
pg_dump: error: query failed: ERROR: permission denied for table pg_statistic_ext
pg_dump: error: query was: SELECT tableoid, oid, stxname, stxnamespace, (SELECT rolname FROM pg_catalog.pg_roles WHERE oid = stxowner) AS rolname FROM pg_catalog.pg_statistic_ext
not ok 4576 - role: pg_dump runs

# Failed test 'role: pg_dump runs'
# at t/002_pg_dump.pl line 3418.

I think probably what's happening is that pg_dump is still trying to dump
directly from the catalog, when what it needs to do now is dump from the
view, in case it's not running as superuser.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-06-16 02:05:44 Re: pgsql: Rework the pg_statistic_ext catalog
Previous Message Tomas Vondra 2019-06-15 23:21:16 pgsql: Fix incorrect CREATE STATISTICS example in docs