| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Hash support for grouping sets |
| Date: | 2017-03-08 18:30:01 |
| Message-ID: | 87zigvy6i3.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Mark" == Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
Mark> Reviewing the patch a bit more, I find it hard to understand the
Mark> comment about passing -1 as a flag for finalize_aggregates. Any
Mark> chance you can spend a bit more time word-smithing that code
Mark> comment?
>> Sure.
>>
>> How does this look for wording (I'll incorporate it into an updated
>> patch later):
Mark> Much better. Thanks!
Here's a version of the patch that obviates that comment entirely, by
moving the differences between the hashed and sorted cases out to the
separate callers of finalize_aggregates.
--
Andrew (irc:RhodiumToad)
| Attachment | Content-Type | Size |
|---|---|---|
| gshash24.patch | text/x-patch | 149.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Bartunov | 2017-03-08 18:36:13 | Re: SQL/JSON in PostgreSQL |
| Previous Message | Robert Haas | 2017-03-08 18:22:18 | Re: Parallel bitmap heap scan |