Skip site navigation (1) Skip section navigation (2)

Re: Bug #758: show_planner_stats does not work for new PREPARE calls

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: barry(at)xythos(dot)com, pgsql-bugs(at)postgresql(dot)org,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Bug #758: show_planner_stats does not work for new PREPARE calls
Date: 2002-09-17 00:45:33
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-bugspgsql-patches
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
> moment, but they used to be used; I think the correct response is to
> put back the missing counter increments, not rip out the counters.

Ok, fair enough. It's worth noting that they've been broken for a
while -- for example, the HashJoin counter increments were broken when
you comitted r1.20 of executor/nodeHashJoin.c in May of '99.

I've attached a revised patch that doesn't remove the counters (but
doesn't increment them either: I'm not sure of all the places where
the counter should be incremented).



Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC

Attachment: prepare_planner_stats-2.patch
Description: text/x-patch (2.0 KB)

In response to


pgsql-bugs by date

Next:From: Ron JohnsonDate: 2002-09-17 00:56:42
Subject: Re: [BUGS] Postgres storing time in strange manner
Previous:From: Neil ConwayDate: 2002-09-17 00:37:35
Subject: Re: Bug #770: 7.2.1 --> 7.2.2 =? Problems with speed

pgsql-patches by date

Next:From: Rod TaylorDate: 2002-09-17 12:24:03
Subject: Re: Bug: COPY IN doesn't test domain constraints
Previous:From: Tom LaneDate: 2002-09-16 21:54:00
Subject: Bug: COPY IN doesn't test domain constraints

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group