Re: Abbreviated keys for Numeric

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>
Subject: Re: Abbreviated keys for Numeric
Date: 2015-03-22 20:01:09
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

So here's a version 3 patch:

1. #ifdefism is reduced to a minimum by (a) desupporting values of NBASE
other than 10000, and (b) keeping the 32bit code, so that there is now
no longer any question of abbreviation not being used (it always is).
So the only #ifs in the code body (rather than declarations) are to
select which implementation of numeric_abbrev_convert_var to use.

2. Some (but not all) stylistic changes have been made following Peter's

3. Buffer management has been simplified by simply allocating the
maximum needed size upfront (since it's only needed for short varlenas).
The truncation behavior has been removed.

4. Updated oid choice etc.

The substance of the code is unchanged from my original patch. I didn't
add diagnostic output to numeric_abbrev_abort, see my separate post
about the suggestion of a GUC for that.

Andrew (irc:RhodiumToad)

Attachment Content-Type Size
numeric_sortsup_v3.patch text/x-patch 16.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-03-22 20:41:19 Re: Zero-padding and zero-masking fixes for to_char(float)
Previous Message Tomas Vondra 2015-03-22 19:59:18 Re: PATCH: numeric timestamp in log_line_prefix