Re: Should contrib modules install .h files?

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should contrib modules install .h files?
Date: 2018-09-15 20:03:47
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>>>>> "Andrew" == Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:

Andrew> So what I propose to do is to commit a cleaned-up version of
Andrew> the patch posted above, with these changes:

Andrew> - install all the plpy_*.h headers, not just a few; I know of no reason
Andrew> to exclude any of them, and in the absence of feedback it seems
Andrew> better to install them all;

Andrew> - tidy up the makefile variables in the python transform modules to
Andrew> remove some duplication

Andrew> - fix to account for the changes

Andrew> This will allow hstore_plperl etc. to stand as examples of how
Andrew> to do cross-module #includes both in and out of tree.

Andrew> I'll post the patch for review shortly.

And here it is.

Andrew (irc:RhodiumToad)

Attachment Content-Type Size
plxs.patch text/x-patch 7.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2018-09-15 22:15:46 Re: Something fishy happening on frogmouth
Previous Message Dmitry Dolgov 2018-09-15 19:52:39 Re: Index Skip Scan