From: | Neil Conway <neilc(at)samurai(dot)com> |
---|---|
To: | Serguei Mokhov <mokhov(at)cs(dot)concordia(dot)ca> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: fix for palloc() of user-supplied length |
Date: | 2002-08-28 04:33:26 |
Message-ID: | 87sn0zy549.fsf@mailbox.samurai.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Serguei Mokhov <mokhov(at)cs(dot)concordia(dot)ca> writes:
> + if (len < 1 || len > 8192)
> + {
> + elog(LOG, "Password packet length too long: %d", len);
> ^^^^^^^^
> Shouldn't it be changed to 'too long || too long' then? ;)
Woops, sorry for being careless. Changed the wording to refer to
'invalid' rather than 'too long' or 'too short'.
> And also for the message to be more descriptive for the innocent, I'd included
> the current boundaries in it (like: "expected: 1 <= len <= 8192")
Also fixed, although I'm not sure it's worth worrying about.
> (a question: isn't hardcoding an evil?)
Yes, probably -- as the comment notes, it is just an arbitrary
limitation. But given that (a) it is extremely unlikely to ever be
encountered in a real-life situation (b) the limits it imposes are
very lax (c) it is temporary code that will be ripped out shortly, I'm
not too concerned...
Thanks for taking a look at the code, BTW.
Cheers,
Neil
--
Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
Attachment | Content-Type | Size |
---|---|---|
ver_zero_auth-3.patch | text/x-patch | 951 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Marc Lavergne | 2002-08-28 04:39:03 | Re: C vs. C++ contributions |
Previous Message | Tom Lane | 2002-08-28 04:29:16 | Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1? |
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2002-08-28 04:54:37 | Anonymous-record-types omission |
Previous Message | Serguei Mokhov | 2002-08-28 04:12:26 | Re: fix for palloc() of user-supplied length |