| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Fix tab completion in v18 for ALTER DATABASE/USER/ROLE ... RESET |
| Date: | 2025-07-16 17:41:42 |
| Message-ID: | 87qzyghw2x.fsf@wibble.ilmari.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
These two patches are split out from my earlier thread about improving
tab completion for varous RESET forms
(https://postgr.es/m/87bjqwwtic.fsf@wibble.ilmari.org) so that the bug
fixes can be tracked as an open item for v18.
Commits 9df8727c5067 and c407d5426b87 added tab completion for ALTER
DATABASE ... RESET and ALTER ROLE/USER ... RESET, respectively, but
they're both differently buggy. The query for the DATABASE form
neglected to schema-qualify the unnest() call, and the query for the
ROLE/USER form shows all possible variables once you start typing a
variable name, not just the ones that are set on the role. The attached
patches fix both.
- ilmari
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Schema-qualify-unnest-call-in-ALTER-DATABASE-.-RESET.patch | text/x-diff | 1.1 KB |
| 0002-Fix-tab-completion-for-ALTER-ROLE-USER-.-RESET.patch | text/x-diff | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-07-16 17:42:30 | Re: index prefetching |
| Previous Message | Nathan Bossart | 2025-07-16 17:26:04 | Re: small fix for pg_overexplain docs |