Re: Aggregate ORDER BY patch

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
Subject: Re: Aggregate ORDER BY patch
Date: 2009-11-30 10:34:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Updated version of the aggregate order by patch.

Includes docs + regression tests all in the same patch.


- removed SortGroupClause.implicit as per review comments,
replacing it with separate lists for Aggref.aggorder and

- Refactored in order to move the bulk of the new parse code
out of ParseFuncOrColumn which was already quite big enough,
into parse_agg.c

- fixed a bug with incorrect deparse in ruleutils (and added a
bunch of regression tests for deparsing and view usage)

- added some comments

Andrew (irc:RhodiumToad)

Attachment Content-Type Size
aorder-20091130.patch.gz application/octet-stream 21.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-11-30 11:23:57 Re: draft RFC: concept for partial, wal-based replication
Previous Message Heikki Linnakangas 2009-11-30 10:08:37 Re: Hot Standby remaining issues