| From: | Andy Fan <zhihuifan1213(at)163(dot)com> |
|---|---|
| To: | Andy Fan <zhihuifan1213(at)163(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: the s_lock_stuck on perform_spin_delay |
| Date: | 2024-01-18 12:54:30 |
| Message-ID: | 87o7diyf3z.fsf@163.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Matthias / Robert:
Do you still have interest with making some progress on this topic?
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>
>> On Wed, Jan 10, 2024 at 10:17 PM Andy Fan <zhihuifan1213(at)163(dot)com> wrote:
>>> fixed in v2.
>>
>> Timing the spinlock wait seems like a separate patch from the new sanity checks.
>
> Yes, a separate patch would be better, so removed it from v4.
>
>> I suspect that the new sanity checks should only be armed in
>> assert-enabled builds.
>
> There are 2 changes in v4. a). Make sure every code is only armed in
> assert-enabled builds. Previously there was some counter++ in non
> assert-enabled build. b). Record the location of spin lock so that
> whenever the Assert failure, we know which spin lock it is. In our
> internal testing, that helps a lot.
v5 attached for fix the linking issue on Windows.
--
Best Regards
Andy Fan
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Detect-more-misuse-of-spin-lock-automatically.patch | text/x-diff | 9.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-01-18 12:55:17 | RE: Synchronizing slots from primary to standby |
| Previous Message | Peter Eisentraut | 2024-01-18 12:53:36 | Re: Built-in CTYPE provider |