Re: Final Patch for GROUPING SETS

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Atri Sharma <atri(dot)jiit(at)gmail(dot)com>
Subject: Re: Final Patch for GROUPING SETS
Date: 2014-08-25 05:21:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Here is the new version of our grouping sets patch. This version
supersedes the previous post.

We believe the functionality of this version to be substantially
complete, providing all the standard grouping set features except T434
(GROUP BY DISTINCT). (Additional tweaks, such as extra variants on
GROUPING(), could be added for compatibility with other databases.)

Since the debate regarding reserved keywords has not produced any
useful answer, the main patch here makes CUBE and ROLLUP into
col_name_reserved keywords, but a separate small patch is attached to
make them unreserved_keywords instead.

So there are now 5 files:

gsp1.patch - phase 1 code patch (full syntax, limited functionality)
gsp2.patch - phase 2 code patch (adds full functionality using the
new chained aggregate mechanism)
gsp-doc.patch - docs
gsp-contrib.patch - quote "cube" in contrib/cube and contrib/earthdistance,
intended primarily for testing pending a decision on
renaming contrib/cube or unreserving keywords
gsp-u.patch - proposed method to unreserve CUBE and ROLLUP

Andrew (irc:RhodiumToad)

Attachment Content-Type Size
gsp1.patch text/x-patch 179.9 KB
gsp2.patch text/x-patch 45.1 KB
gsp-doc.patch text/x-patch 13.6 KB
gsp-contrib.patch text/x-patch 228.3 KB
gsp-u.patch text/x-patch 5.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2014-08-25 05:35:02 Re: WIP Patch for GROUPING SETS phase 1
Previous Message Guillaume Lelarge 2014-08-25 05:12:33 Re: Maximum number of WAL files in the pg_xlog directory