Skip site navigation (1) Skip section navigation (2)

Re: latest hstore patch

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: david(at)kineticode(dot)com ("David E(dot) Wheeler"), pgsql-hackers(at)postgresql(dot)org
Subject: Re: latest hstore patch
Date: 2009-09-24 00:27:29
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
>>>>> "David" == "David E Wheeler" <david(at)kineticode(dot)com> writes:

 David> Just a few thoughts for discussion:

 David> * From my previous posts: Is it time to kill off `(at)` and `~`,?
 David> Not necessarily for your patch to handle, just wondering what
 David> others think.

I'll take them out if people think that is appropriate.

 David> * I like the %% operator for converting to arrays. Though I
 David> think maybe I would have liked %@ better, but maybe that's
 David> just the Perl hacker in me.

I originally tried just % but something in the grammar stops you using
that for a unary op.

 David> * I also like the new %# operator to convert to
 David> two-dimensional arrays. But if you adopted %@ for arrays,
 David> maybe %@@ better indicates a 2-dimensional array? I'm just
 David> thinking out lout here, I'm happy to have them no matter what
 David> they're called.

%@@ is a bit on the ugly side for an operator I think.

 David> * More name stuff: Why `hstore_to_list` rather than
 David> `hstore_to_array`?  And I'm not sure about `hstore_to_matrix`
 David> for the 2-dimensional array.  I guess that's better than
 David> `hstore_to_multidimensional_array` would be. ;-)

I intentionally avoided hstore_to_array because it would be unclear
which one it meant (the 1-d or 2-d result).

Andrew (irc:RhodiumToad)

In response to


pgsql-hackers by date

Next:From: KaiGai KoheiDate: 2009-09-24 01:19:10
Subject: Re: [PATCH] Largeobject access controls
Previous:From: Tom LaneDate: 2009-09-24 00:25:13
Subject: Re: pg_hba.conf: samehost and samenet [REVIEW]

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group