Re: [PATCH] pgpassfile connection option

From: Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pgpassfile connection option
Date: 2016-11-11 09:22:52
Message-ID: 87E81BF8-D177-45AF-BA68-23A0DF28D840@uni-muenster.de
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

I've updated my patch to work with the changes introduced to libpq by allowing multiple hosts.
On Fabien's recommendations, I've kept the variable dot_pgpassfile_used, however I renamed that to pgpassfile_used, to keep a consistent naming scheme.
I'm still not sure about the amount of error messages produced by libpq, I think it would be ideal to report an error while accessing a file provided in the connection string, however I would not report that same type of error when the .pgpass file has been tried to retrieve a password.
(Else, you'd get an error message on every connection string that doesn't specify a pgpassfile or password, since .pgpass will be checked every time, before prompting the user to input the password)

regards,
Julian Markwort

Attachment Content-Type Size
pgpassfile_v4.patch application/octet-stream 9.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2016-11-11 09:31:23 Re: Remove the comment on the countereffectiveness of large shared_buffers on Windows
Previous Message Craig Ringer 2016-11-11 09:10:16 [PATCH] Allow TAP tests to be run individually