Re: pgsql: Remove secondary checkpoint

From: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: pgsql: Remove secondary checkpoint
Date: 2017-11-11 17:28:14
Message-ID: 878tfcsp1t.fsf@ansel.ydns.eu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

sqlsmith doesn't like commit 4b0d28de06:

,----
| regression=> select * from pg_control_checkpoint();
| server closed the connection unexpectedly
| TRAP: FailedAssertion("!((atti->attalign) == 's')", File: "heaptuple.c", Line: 126)
`----

On a build with assertions disabled, the statement fails with an error
instead:

,----
| regression=> select * from pg_control_checkpoint();
| ERROR: function return row and query-specified return row do not match
| DETAIL: Returned row contains 19 attributes, but query expects 18.
`----

The attached patch fixes it for me.

regards,
Andreas

Attachment Content-Type Size
0001-Fix-pg_control_checkpoint.patch text/x-diff 1.1 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2017-11-11 20:02:56 pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.
Previous Message Robert Haas 2017-11-10 21:55:35 pgsql: Account for the effect of lossy pages when costing bitmap scans.