strxfrm implementation

From: Greg Stark <gsstark(at)mit(dot)edu>
To: pgsql-hackers(at)postgresql(dot)org
Subject: strxfrm implementation
Date: 2005-01-25 18:06:12
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Today someone posted (or tried to post, I didn't get the attachment) an
implementation of strxfrm using setlocale again. I think this is the second or
third time someone has tried their hand at this. Clearly there's a demand for
it and I fear some of the users trying to do this aren't aware of all the
problems that were identified a couple years ago on this list.

I think the best implementation so far is Joe Conway's that used
sigsetjmp/siglongjmp to catch errors safely. I would strongly suggest putting
this implementation in contrib to save all those people from repeating the
same mistakes I made and others have made. Especially since the consequences
of those mistakes include potentially corrupting the database.

I would suggest it be put in the core system except that as has been pointed
out the performance isn't satisfactory on every platform. The only platform we
have confirmation that the performance is reasonable is glibc-based systems.

Attachment Content-Type Size
strxfrm2.c text/x-csrc 4.4 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-01-25 18:09:08 Heads up: upcoming releases in all branches back to 7.2
Previous Message Michael Fuhr 2005-01-25 18:00:32 Re: Is this a bug?