From: | Greg Stark <gsstark(at)mit(dot)edu> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Subject: | CREATE TABLE LIKE x INCLUDING CONSTRAINTS |
Date: | 2006-06-20 22:05:44 |
Message-ID: | 877j3b4h53.fsf@stark.xeocode.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Fixed previous patch by calling change_varattnos_of_a_node() to fix up
constraint expressions in case attribute positions don't line up.
change_varattnos_of_a_node is in tablecmds.c for inherited tables so this
means making it extern. I have a feeling it probably ought to move to some
file of functions for manipulating Nodes but I couldn't really find an
appropriate place. At first I was going to put it in ruleutils.c but then it
seems the other functions in that file go in builtins.h which would be a
strange place for this I think.
So in the end I left the functions in tablecmds.[ch] at least until someone
more familiar with the source tree suggests another pair of files for them to
be defined in.
Attachment | Content-Type | Size |
---|---|---|
like.patch4 | application/octet-stream | 23.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2006-06-21 03:13:13 | Re: CREATE TABLE LIKE x INCLUDING CONSTRAINTS |
Previous Message | Joachim Wieland | 2006-06-19 23:18:10 | doc & regress for full time zone names |