Re: [HACKERS] PoC: custom signal handler for extensions

From: David Steele <david(at)pgmasters(dot)net>
To: Maksim Milyutin <milyutinma(at)gmail(dot)com>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] PoC: custom signal handler for extensions
Date: 2018-03-05 19:21:36
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Maksim,

On 3/5/18 11:24 AM, Maksim Milyutin wrote:
> Hello David,
> On 05.03.2018 18:50, David Steele wrote:
>> Hello Maksim,
>> On 1/27/18 2:19 PM, Arthur Zakirov wrote:
>>> Is there actual need in UnregisterCustomProcSignal() within _PG_init()?
>>> An extension registers a handler and then unregister it doing
>>> nothing. It seems useless.
>>> Also process_shared_preload_libraries_in_progress within _PG_fini() will
>>> be false I think. _PG_fini() won't be called though, because
>>> implementation of internal_unload_library() is disabled.
>>> Actually, is there need in UnregisterCustomProcSignal() at all? It
>>> unregisters a handler only in current backend, for actual unergistering
>>> we need to call it everywhere, if I'm not mistaken.
>> This patch has been in Waiting on Author state for almost three weeks.
>> Have you had a chance to consider Arthur's suggestions?
> Yes, I want to rework my patch to enable setup of custom signals on
> working backend without preload initialization.
>> Do you know when you'll have an updated patch available?
> I want to actuate the work on this patch for the next 12 release. Sorry,
> for now I can not keep up with the current release.
Understood. I'll mark it Returned with Feedback and you can enter it in
a CF when you have a new patch.


In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-03-05 19:34:16 Re: [HACKERS] user-defined numeric data types triggering ERROR: unsupported type
Previous Message Tom Lane 2018-03-05 19:19:12 Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly