| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | David Zhang <david(dot)zhang(at)highgo(dot)ca>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allow continuations in "pg_hba.conf" files |
| Date: | 2020-09-04 15:00:31 |
| Message-ID: | 875646.1599231631@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> I notice that buf.data is not freed. I guess that the server memory
> management will recover it.
Yeah, it's in the transient context holding all of the results of
reading the file. I considered pfree'ing it at the end of the
function, but I concluded there's no point. The space will be
recycled when the context is destroyed, and since we're not (IIRC)
going to allocate anything more in that context, nothing would be
gained by freeing it earlier --- it'd just stay as unused memory
within the context.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-09-04 15:04:46 | Re: [PATCH]Fix ja.po error |
| Previous Message | Tomas Vondra | 2020-09-04 14:57:51 | Re: Ideas about a better API for postgres_fdw remote estimates |