Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: YunQiang Su <wzssyqa(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Date: 2019-06-17 16:50:22
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

Andres Freund <andres(at)anarazel(dot)de> writes:
> I think we're pretty much at the point where we should just rip out all
> of our own spinlock implementations for non-common platforms, and solely
> rely on compiler intrinsics... The open coded ASM really doesn't age
> very well, and there's very little chance of us actually testing them
> properly.

It's completely not true that this code isn't tested; we have two
different MIPS buildfarm machines that surely exercise spinlocks plenty.

(There's a separate argument to be had about whether we should drop
source-code support for platforms that aren't represented in the
buildfarm. I'm not inclined to, but you could tenably hold that

As for compiler intrinsics, I dunno. I don't have very much faith in
the quality of those for non-mainstream platforms, either --- see
for a not-too-old example. And a lot of platforms like this are running
pretty old compilers, so even if the problems have been fixed it'll be a
long time before we can depend on that.

regards, tom lane

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2019-06-18 06:39:20 BUG #15857: Parallel Hash Join makes join instead of exists
Previous Message Andres Freund 2019-06-17 16:48:39 Re: BUG #15851: Concurrent Refresh of Materialized views not preserving the order of the underlying query