Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused
Date: 2018-09-13 17:50:13
Message-ID: 871s9xnvvs.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Here's what I have queued up to push.

My changes are:

- added to the header comment of list_concat_unique that callers have
ordering expectations. Didn't touch list_union, since I ended up
sticking with list_concat_unique for this patch.

- WindowClauseSortNode renamed WindowClauseSortData

- added and rewrote some comments

- tidied up some casting in common_prefix_cmp

- pgindent and some layout tweaks

--
Andrew (irc:RhodiumToad)

Attachment Content-Type Size
0001-Order-active-window-clauses-for-greater-reuse-of-Sor.patch text/x-patch 13.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-09-13 18:19:47 Re: [HACKERS] Bug in to_timestamp().
Previous Message Andres Freund 2018-09-13 17:43:18 Re: [patch] Support LLVM 7