Re: test/example does not support win32.

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>, "Bruce Momjian" <bruce(at)momjian(dot)us>
Subject: Re: test/example does not support win32.
Date: 2009-12-30 16:21:31
Message-ID: 870E860C34384616973A0ED526D0DDF7@acer08f817a9b5
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Andrew-san.

This saves a windows users.
I appreciate your suggestion.
Thanks!

P.S)
I often use by the test by nmake at the time of independent creation of libpq.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>

>
>
> Hiroshi Saito wrote:
>> Hi Andrew-san.
>>
>> Although this is a standard in windows.
>>
>> *** testlibpq2.c.orig Wed Dec 30 13:19:03 2009
>> --- testlibpq2.c Thu Dec 31 00:52:52 2009
>> ***************
>> *** 24,34 ****
>> --- 24,39 ----
>> *
>> * INSERT INTO TBL1 VALUES (10);
>> */
>> +
>> + #ifdef WIN32
>> + #include <windows.h>
>> + #endif
>> #include <stdio.h>
>> #include <stdlib.h>
>> #include <string.h>
>> #include <errno.h>
>> #include <sys/time.h>
>> + #include <sys/types.h>
>> #include "libpq-fe.h"
>>
>> static void
>>
>> Does this become the standard which you consider?
>> or #IFDEF Isn't it allowed?
>>
>>
> I certainly think we can use ifdefs. This addition seems OK to me at
> first glance. Does it solve the problem you encountered?
>
> cheers
>
> andrew

Attachment Content-Type Size
examples_win32_patch2 application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2009-12-30 16:24:42 Re: test/example does not support win32.
Previous Message Robert Haas 2009-12-30 16:20:31 Re: Stats for inheritance trees