Re: Verbosity of genbki.pl

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, John Naylor <jcnaylor(at)gmail(dot)com>
Subject: Re: Verbosity of genbki.pl
Date: 2018-04-28 15:34:36
Message-ID: 867f8a1a-6cf0-d835-78d8-0844e4936241@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/9/18 15:02, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On 2018-04-08 13:33:42 -0400, Tom Lane wrote:
>>> Traditionally genbki.pl has printed "Writing foo" for every file
>>> it writes out.
>
>>> 2. Print just one message like "Generating postgres.bki and related
>>> files", and I guess a second one for fmgroids.h and related files.
>
>> +0.5.
>
> Hearing no votes against, done that way.

Maybe we can take another look at this. Right now, make -s world
produces *only* the following output:

$ make -s world
Generating BKI files and symbol definition headers...
Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...
PostgreSQL, contrib, and documentation successfully made. Ready to install.

That seems kind of inconsistent and silly. I suggest we remove the
output from these scripts.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2018-04-28 15:35:48 Re: Postgres, fsync, and OSs (specifically linux)
Previous Message Simon Riggs 2018-04-28 15:25:53 Re: Postgres, fsync, and OSs (specifically linux)