| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org>, "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "a(dot)lubennikova(at)postgrespro(dot)ru" <a(dot)lubennikova(at)postgrespro(dot)ru>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "matsumura(dot)ryo(at)fujitsu(dot)com" <matsumura(dot)ryo(at)fujitsu(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive status ".ready" files may be created too early |
| Date: | 2021-08-06 18:26:12 |
| Message-ID: | 867B852E-E892-4DD7-8E29-CE74FDBBA234@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/6/21, 12:42 AM, "Kyotaro Horiguchi" <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> In v5, NotifySegmentsReadyForArchive() still holds ArchNotifyLock
> including .ready file creations. Since the notification loop doesn't
> need the hash itself, the loop can be took out of the lock section?
I think that works. This creates another opportunity for archive
status files to be created out of order, but as discussed elsewhere, I
think we have to be prepared for that regardless. I moved the
notification loop out of the lock section in v6.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Avoid-creating-archive-status-.ready-files-too-ea.patch | application/octet-stream | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-08-06 18:41:22 | Re: OpenSSL 3.0.0 compatibility |
| Previous Message | Japin Li | 2021-08-06 16:27:36 | Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |