Re: automating RangeTblEntry node support

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: automating RangeTblEntry node support
Date: 2024-01-15 10:37:15
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 06.12.23 21:02, Peter Eisentraut wrote:
> I have been looking into what it would take to get rid of the
> custom_read_write and custom_query_jumble for the RangeTblEntry node
> type.  This is one of the larger and more complex exceptions left.
> (Similar considerations would also apply to the Constraint node type.)

In this updated patch set, I have also added the treatment of the
Constraint type. (I also noted that the manual read/write functions for
the Constraint type are out-of-sync again, so simplifying this would be
really helpful.) I have also added commit messages to each patch.

The way I have re-ordered the patch series now, I think patches 0001
through 0003 are candidates for inclusion after review, patch 0004 still
needs a bit more analysis and testing, as described therein.

Attachment Content-Type Size
v2-0001-Remove-custom-Constraint-node-read-write-implemen.patch text/plain 13.2 KB
v2-0002-Remove-custom-_jumbleRangeTblEntry.patch text/plain 7.8 KB
v2-0003-Simplify-range_table_mutator_impl.patch text/plain 3.4 KB
v2-0004-WIP-Remove-custom-RangeTblEntry-node-read-write-i.patch text/plain 7.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-01-15 10:39:26 Re: Synchronizing slots from primary to standby
Previous Message Bertrand Drouvot 2024-01-15 10:17:34 Re: System username in pg_stat_activity