| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Subject: | Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore |
| Date: | 2026-07-04 22:57:53 |
| Message-ID: | 83daa551-5f45-4683-920f-e62ed94b06a8@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/07/2026 01:28, Jelte Fennema-Nio wrote:
>> The comments you added in your patches help a lot, explaining the three
>> different ways that cancellation can be handled, thanks for that.
>
> Yeah, I think
I extracted just the comment in fe_utils/cancel.c to a separate patch,
and modified it to reflect the reality before the rest of the changes.
I'm inclined to commit that now to document the status quo. That'll also
make it easier to see what the other patches change. Does the attached
look correct to you?
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-comment-to-describe-the-various-frontend-cancel-.patch | text/x-patch | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Nestorov | 2026-07-04 23:00:19 | Re: [PATCH] btree_gist: add cross-type integer operator support for GiST |
| Previous Message | Noah Misch | 2026-07-04 22:12:10 | SECURITY LABEL ON PROPERTY GRAPH: supported? |