Re: Adding column_constraint description in ALTER TABLE synopsis

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Stephen Frost <sfrost(at)snowman(dot)net>, Lætitia Avrot <laetitia(dot)avrot(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Adding column_constraint description in ALTER TABLE synopsis
Date: 2017-11-01 00:35:50
Message-ID: 82f53e77-6ee5-d4be-bd5a-f9cfe245e83d@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2017/10/31 21:31, Stephen Frost wrote:
> * Lætitia Avrot (laetitia(dot)avrot(at)gmail(dot)com) wrote:
>> As Amit Langot pointed out, the column_constraint definition is missing
>> whereas it is used in ALTER TABLE synopsis. It can be easily found in the
>> CREATE TABLE synopsis, but it's not very user friendly.
>
> Thanks, this looks pretty reasonable, but did you happen to look for any
> other keywords in the ALTER TABLE that should really be in ALTER TABLE
> also?
>
> I'm specifically looking at, at least, partition_bound_spec. Maybe you
> could propose an updated patch which addresses that also, and any other
> cases you find?

Ah, yes. I remember having left out partition_bound_spec simply because I
thought it was kind of how it was supposed to be done, seeing that neither
column_constraint and table_constraint were expanded in the ALTER TABLE's
synopsis.

It seems that there are indeed a couple of other things that need to be
brought over to ALTER TABLE synopsis including partition_bound_spec.
9f295c08f877 [1] added table_constraint, but missed to add the description
of index_parameters and exclude_element which are referenced therein.

Attached find updated version of the Lætitia's patch.

Thanks,
Amit

[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9f295c

Attachment Content-Type Size
adding_column_constraint_description_in_ALTER_TABLE_synopsis_v2.patch text/plain 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-11-01 01:11:29 Re: Parallel tuplesort (for parallel B-Tree index creation)
Previous Message David Rowley 2017-11-01 00:09:13 Removing LEFT JOINs in more cases