| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | pg_regress: Treat child process failure as test failure |
| Date: | 2022-11-26 20:11:39 |
| Message-ID: | 82C46B5E-1821-4039-82C2-56BCA5992989@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In the thread about TAP format out in pg_regress, Andres pointed out [0] that
we allow a test to pass even if the test child process failed. While its
probably pretty rare to have a test pass if the process failed, this brings a
risk for false positives (and it seems questionable that any regress test will
have a child process failing as part of its intended run).
The attached makes child failures an error condition for the test as a belts
and suspenders type check. Thoughts?
--
Daniel Gustafsson https://vmware.com/
[0] https://postgr.es/m/20221122235636.4frx7hjterq6bmls@awork3.anarazel.de
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Consider-a-failed-test-process-as-a-failed-test.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-11-26 20:35:45 | Re: TAP output format in pg_regress |
| Previous Message | Jonathan S. Katz | 2022-11-26 19:53:44 | Re: User functions for building SCRAM secrets |