| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> | 
|---|---|
| To: | pgsql-hackers(at)postgreSQL(dot)org | 
| Subject: | incorrect docs for pgbench / skipped transactions | 
| Date: | 2016-03-19 01:42:42 | 
| Message-ID: | 825589cb-b5ed-cee5-b246-33d59a5aead0@2ndquadrant.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Hi,
while learning about format of the transaction log produced by pgbench, 
I've noticed this sentence in the section describing format of the 
per-transaction log:
    The last field skipped_transactions reports the number of
    transactions skipped because they were too far behind schedule.
    It is only present when both options --rate and --latency-limit
    are used.
Which is wrong, because this field is only added in the aggregated log, 
not in the per-transaction one. So we should delete this.
It also does not explicitly explain that with --latency-limit the 
latency column will contain "skipped" for transactions exceeding the 
limit latency (it's only mentioned in the example output).
So I think we should apply the attached patch (and also backpatch it to 
9.5, where the --latency-limit got introduced).
regards
-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size | 
|---|---|---|
| pgbench-skipped-doc-fix.patch | binary/octet-stream | 854 bytes | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2016-03-19 02:08:41 | Re: Idle In Transaction Session Timeout, revived | 
| Previous Message | Jeff Janes | 2016-03-19 01:12:12 | Re: Weighted Stats |