| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Sami Imseih <samimseih(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix bug in multixact Oldest*MXactId initialization and access |
| Date: | 2026-03-03 16:59:34 |
| Message-ID: | 824fe90a-9954-4964-a177-bc8789f06d13@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/03/2026 17:22, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Ok, here's another version of Sami's repro. I realized that it doesn't
>> even need concurrent sessions, so I moved it to the main regression test
>> suite, into the 'prepared_xacts' test. Looks good?
>
> Not directly relevant to the thing being tested here, but ...
> I wonder if we couldn't reduce future maintenance effort for
> prepared_xacts_1.out by modifying that test script to make an
> early exit if prepared transactions are disabled.
+1, I was just thinking the same.
Here's a patch to do that. I'll backpatch this to all supported
versions, to make backpatching test changes less painful in the future.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Skip-prepared_xacts-test-if-max_prepared_transact.patch | text/x-patch | 9.4 KB |
| v2-0002-Add-test-for-row-locking-and-multixids-with-prepa.patch | text/x-patch | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2026-03-03 17:01:43 | Re: Show expression of virtual columns in error messages |
| Previous Message | Álvaro Herrera | 2026-03-03 16:23:58 | Re: updates for handling optional argument in system functions |