Re: Creating a function for exposing memory usage of backend process

On Wed, Jul 1, 2020 at 10:15 PM torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
wrote:
> I'm going to do some renaming and transportations.
>
> - view name: pg_memory_contexts
> - function name: pg_get_memory_contexts()
> - source file: mainly src/backend/utils/mmgr/mcxt.c

Attached an updated patch.

On Wed, Jul 1, 2020 at 10:58 PM Fujii Masao
<masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> Ok, understood! I agree that it's strange to display different names
> for the same memory context between this view and logging.
>
> It's helpful if the comment there refers to MemoryContextStatsPrint()
> and mentions the reason that you told.

Agreed. I changed the comments.

> > It also derived from MemoryContextStatsPrint().
> > I suppose it is for keeping readability of the log..
>
> Understood. I may want to change the upper limit of query size to
> display.
> But at the first step, I'm fine with limitting 1024 bytes.

Thanks, I've left it as it was.

> > I'm going to follow the discussion on the mailing list and find why
> > these codes were introduced.
>
> https://www.postgresql.org/message-id/12319.1521999065%40sss.pgh.pa.us

Thanks for sharing!

Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION