Re: is_superuser is not documented

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Joseph Koshakow <koshy44(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: is_superuser is not documented
Date: 2023-04-12 15:03:45
Message-ID: 7b88d4b4-d752-19a5-e4a8-471f2d70eed2@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023/04/12 5:41, Joseph Koshakow wrote:
> Having said all that I actually think this is the best place for
> is_superuser since it doesn't seem to fit in anywhere else.

Yeah, I also could not find more appropriate place for is_superuser than there.

> I was implying that I thought it would have made more sense for
> is_superuser to be implemented as a function, behave as a function,
> and not be visible via SHOW. However, there may have been a good reason
> not to do this and it may already be too late for that.

The is_superuser parameter is currently marked as GUC_REPORT and
its value is automatically reported to a client. If we change
it to a function, we will need to add functionality to automatically
report the return value of the function to a client, which could
be overkill.

> In my opinion, this is ready to be committed.

Thanks! Given that we have already exceeded the feature freeze date,
I'm thinking to commit this change at the next CommitFest.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-04-12 15:30:28 Re: meson documentation build open issues
Previous Message Robert Haas 2023-04-12 15:01:28 Re: [PATCH] Allow Postgres to pick an unused port to listen