Re: postgres_fdw bug in 9.6

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres_fdw bug in 9.6
Date: 2017-03-23 12:20:54
Message-ID: 79b98e30-4d38-7deb-f1fb-bc0bc589a958@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2017/03/21 18:40, Etsuro Fujita wrote:
> Ok, I'll update the patch. One thing I'd like to revise in addition to
> that is (1) add to JoinPathExtraData a flag member to indicate whether
> to give the FDW a chance to consider a remote join, which will be set to
> true if the joinrel's fdwroutine is not NULL and the fdwroutine's
> GetForeignJoinPaths is not NULL, and (2) if the flag is true, save info
> to create an alternative local join path, such as hashclauses and
> mergeclauses proposed in the patch, into JoinPathExtraData in
> add_paths_to_joinrel. This would avoid useless overhead in saving such
> info into JoinPathExtraData when we don't give the FDW that chance.

Done. Attached is a new version of the patch.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
epqpath-for-foreignjoin-6.patch binary/octet-stream 45.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-03-23 12:23:35 Re: Monitoring roles patch
Previous Message Magnus Hagander 2017-03-23 11:41:54 Re: Create replication slot in pg_basebackup if requested and not yet present