Re: Error detail/hint style fixup

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: Error detail/hint style fixup
Date: 2018-03-23 07:57:23
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 22 Mar 2018, at 22:38, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> This stuff seems reasonably non-controversial, so pushed.


> BTW, really the point of what I'd mentioned before was to avoid having
> dblink_res_error constructing a message out of fragments, which it's
> still doing. I'd thought perhaps we would shove the responsibility for
> mentioning the connection name out to the callers to get rid of that.
> But handling the possibility of an unnamed connection seems like it'd
> complicate the callers considerably. And as long as we don't actually
> have translation support in that module, it'd just be make-work, so
> I didn't do it.

Right, that would be a lof of complexity for no real gain until dblink is

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-03-23 08:01:11 Re: Protect syscache from bloating with negative cache entries
Previous Message Michael Paquier 2018-03-23 07:49:56 Re: Problem while setting the fpw with SIGHUP