Re: Extra quote_all_identifiers in _dumpOptions

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Extra quote_all_identifiers in _dumpOptions
Date: 2019-07-09 08:10:49
Message-ID: 7967be19-322c-ec5e-ac93-61a3c3092cce@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.07.2019 02:32, Bruce Momjian wrote:
>> diff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.h
>> index db30b54a92..8c0cedcd98 100644
>> --- a/src/bin/pg_dump/pg_backup.h
>> +++ b/src/bin/pg_dump/pg_backup.h
>> @@ -153,7 +153,6 @@ typedef struct _dumpOptions
>> int no_synchronized_snapshots;
>> int no_unlogged_table_data;
>> int serializable_deferrable;
>> - int quote_all_identifiers;
>> int disable_triggers;
>> int outputNoTablespaces;
>> int use_setsessauth;
>
> Wow, good catch. I thought C compilers would have reported this issue,
> but obviously not. Patch applied to head. Thanks.

Thank you, Bruce!

--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-07-09 08:23:23 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)
Previous Message Julien Rouhaud 2019-07-09 07:52:38 Re: Add parallelism and glibc dependent only options to reindexdb