| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-decimal integer literals |
| Date: | 2022-11-22 13:36:45 |
| Message-ID: | 791aee01-f488-0706-2694-08c5b57a3bdd@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15.11.22 11:31, Peter Eisentraut wrote:
> On 14.11.22 08:25, John Naylor wrote:
>> Regarding the patch, it looks good overall. My only suggestion would
>> be to add a regression test for just below and just above overflow, at
>> least for int2.
>
> ok
This was a valuable suggestion, because this found some breakage. In
particular, the handling of grammar-level literals that overflow to
"Float" was not correct. (The radix prefix was simply stripped and
forgotten.) So I added a bunch more tests for this. Here is a new patch.
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Non-decimal-integer-literals.patch | text/plain | 39.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-11-22 13:45:17 | Re: fixing CREATEROLE |
| Previous Message | Ashutosh Bapat | 2022-11-22 13:10:01 | Re: postgres_fdw binary protocol support |