Re: Proposed patch for sequence-renaming problems

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Proposed patch for sequence-renaming problems
Date: 2005-09-28 02:38:50
Message-ID: 786.1127875130@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I looked over the patch, and while it does fix the problem for SERIAL, I
> am concerned about expecting users to user ::regclass in normal usage,
> and I am concerned about adding something we will have to support in the
> future when we come up with a better solution. Why is regclass not
> being used automatically?

If we provide both nextval(text) and nextval(regclass), then the parser
will interpret "nextval('something')" as nextval(text) because that's
the more preferred resolution of an unknown-type literal. The only way
to make regclass be used "automatically" would be to remove the
text-input variant. That is where I want to go eventually, but it seems
pretty risky to jump there in one step. The proposed patch adds
regclass-based functions alongside the existing functionality, so that
people can migrate as they choose; it does not open any risks of
breaking cases that work now.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Browne 2005-09-28 03:22:12 Re: State of support for back PG branches
Previous Message Bruce Momjian 2005-09-28 01:58:01 Re: Open items list for 8.1

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-09-28 03:48:56 Re: Proposed patch for sequence-renaming problems
Previous Message Kris Jurka 2005-09-28 01:18:15 high values for client_min_messages