| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql-server/ oc/src/sgml/runtime.sgml rc/back ... |
| Date: | 2003-10-05 15:45:40 |
| Message-ID: | 784.1065368740@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Peter Eisentraut wrote:
>> Given that new languages don't tend to appear out of the blue, I think
>> it's reasonable to design the feature considering the languages currently
>> available.
I think that position is sufficiently rebutted by Bruce's observation:
> Once we put a GUC value in a dump, we have to keep that parameter valid
> almost forever.
Since we are inventing this thing specifically to put it in dump files,
we had better take a very long-term view of its purposes.
>> None of these languages except the
>> first two have anything to gain, but everything to lose, if they were
>> asked not to check the function body during a dump restore.
That's why the code leaves it up to the individual validator routine how
much to check or not check depending on the flag setting. I have no
problem with an individual language deciding that it should or shouldn't
do a particular check. I do think that we'd be foolish to make advance
judgements about what those decisions will be.
Bottom line is that I wouldn't object to changing the switch name to
something more general ("restore_validation_mode", maybe?) but I think
that changing it to something more specific would be a mistake in the
long run.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut - PostgreSQL | 2003-10-05 21:49:12 | pgsql-server/src/backend/catalog aclchk.c |
| Previous Message | Bruce Momjian | 2003-10-05 14:32:14 | Re: pgsql-server/ oc/src/sgml/runtime.sgml rc/back ... |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-10-05 16:00:25 | Re: Day of week question |
| Previous Message | Andreas Pflug | 2003-10-05 15:11:20 | Re: PQfnumber and quoted identifiers |