Re: [COMMITTERS] pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.
Date: 2010-12-12 19:15:18
Message-ID: 7725.1292181318@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Sun, Dec 12, 2010 at 19:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It's a fair question. We could clean up some of these messy ifdefs
>> if we dropped support for that combination. I assume that an MSVC-built
>> libpq.dll would still work for Borland users, no?

> The dynamic one, yes. Static linked one, no.

> IIRC I suggest desupporting it every now and then and get voted down
> ;) And quite often we have someone showing up around the x.y.2 release
> to clean it up so it works again...

Yeah, a look in the commit logs shows that happening about once a year.
It'd sure be nice if we had a less haphazard process for it though.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-12-12 20:10:21 pgsql: Reset all database-level stats in pgstat_recv_resetcounter().
Previous Message Magnus Hagander 2010-12-12 19:07:30 Re: [COMMITTERS] pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-12-12 19:22:03 Re: unlogged tables
Previous Message Magnus Hagander 2010-12-12 19:07:30 Re: [COMMITTERS] pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.