Re: Patch for migration of the pg_commit_ts directory

Hi,

fix error compile

----------------

Кому: Hayato Kuroda (Fujitsu) (kuroda(dot)hayato(at)fujitsu(dot)com), Masahiko Sawada (sawada(dot)mshk(at)gmail(dot)com);

Копия: pgsql-hackers(at)postgresql(dot)org, orlovmg(at)gmail(dot)com, amit(dot)kapila16(at)gmail(dot)com;

Тема: Patch for migration of the pg_commit_ts directory;

05.04.2026, 23:27, "ls7777" <ls7777(at)yandex(dot)ru>:

Hi,


 


I fixed the compiler warnings.


 



I want to ask. Do I need to restore replication sources in my patch created by calling the pg_replication_origin_create function?


Currently, these replication sources are not being migrated to the new cluster.



Maybe it should be done later. If there are users who use it.


 




----------------


Кому: Hayato Kuroda (Fujitsu) (kuroda(dot)hayato(at)fujitsu(dot)com), Masahiko Sawada (sawada(dot)mshk(at)gmail(dot)com);


Копия: pgsql-hackers(at)postgresql(dot)org, orlovmg(at)gmail(dot)com, amit(dot)kapila16(at)gmail(dot)com;


Тема: Patch for migration of the pg_commit_ts directory;


21.03.2026, 13:59, "ls7777" <ls7777(at)yandex(dot)ru>:




Hi,


 



The patch has been significantly updated.


1. Added the --pg-commit-ts command line key for pg_upgrade.


Migration of the pg_commit_ts directory will be performed only if the user explicitly wishes.


2. The roident values are being transferred from pg_replication_origin to a new cluster to resolve conflict messages {UPDATE|DELETE}_ORIGIN_DIFFERS.


 


During testing, it turned out that the replication sources created by the pg_replication_origin_create('no_link_sub_4') functions are not migrated to the new cluster. This is probably a bug.


 


The principle of operation: A query to the old cluster generates SQL commands for roident adjustments, which are then executed in the new cluster.