| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Tommy Pavlicek <tommypav122(at)gmail(dot)com>, daniel(at)yesql(dot)se, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] ltree hash functions |
| Date: | 2024-03-21 22:29:43 |
| Message-ID: | 755500.1711060183@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
jian he <jian(dot)universality(at)gmail(dot)com> writes:
> I also made the following changes:
> from
> uint64 levelHash = hash_any_extended((unsigned char *) al->name, al->len, seed);
> uint32 levelHash = hash_any((unsigned char *) al->name, al->len);
> to
> uint64 levelHash = DatumGetUInt64(hash_any_extended((unsigned char *)
> al->name, al->len, seed));
> uint32 levelHash = DatumGetUInt32(hash_any((unsigned char *) al->name,
> al->len));
Yeah, that'd fail on 32-bit machines.
Pushed v5 with some minor cosmetic tweaking.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2024-03-21 22:31:37 | Re: documentation structure |
| Previous Message | Peter Eisentraut | 2024-03-21 22:20:05 | Re: Adding comments to help understand psql hidden queries |