| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: pgsql: walreceiver uses a temporary replication slot by default |
| Date: | 2020-01-22 15:58:46 |
| Message-ID: | 753391579708726@iva3-77ae5995f07f.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hello
> In short, the following things:
> - wal_receiver_create_temp_slot should be made PGC_POSTMASTER,
> similarly to primary_slot_name and primary_conninfo.
> - WalReceiverMain() should not load the parameter from the GUC context
> by itself.
> - RequestXLogStreaming(), called by the startup process, should be in
> charge of defining if a temp slot should be used or not.
I would like to cross-post here a patch with such changes that I posted in "allow online change primary_conninfo" thread.
This thread is more appropriate for discussion about wal_receiver_create_temp_slot.
PS: I posted this patch in both threads mostly to make cfbot happy.
regards, Sergei
| Attachment | Content-Type | Size |
|---|---|---|
| 0001_v7_move_temp_slot_logic_to_startup.patch | text/x-diff | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-01-22 21:42:09 | pgsql: Add BRIN test case |
| Previous Message | Michael Paquier | 2020-01-22 05:55:10 | Re: pgsql: walreceiver uses a temporary replication slot by default |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2020-01-22 16:04:41 | Re: Index Skip Scan |
| Previous Message | Sergei Kornilov | 2020-01-22 15:51:06 | Re: allow online change primary_conninfo |