Re: tablecmds.c/MergeAttributes() cleanup

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tablecmds.c/MergeAttributes() cleanup
Date: 2023-08-29 08:43:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 12.07.23 16:29, Peter Eisentraut wrote:
> On 11.07.23 20:17, Alvaro Herrera wrote:
>> I spent a few minutes doing a test merge of this to my branch with NOT
>> NULL changes.  Here's a quick review.
>>> Subject: [PATCH 01/17] Remove obsolete comment about OID support
>> Obvious, trivial.  +1
>>> Subject: [PATCH 02/17] Remove ancient special case code for adding
>>> oid columns
>> LGTM; deletes dead code.
>>> Subject: [PATCH 03/17] Remove ancient special case code for dropping oid
>>>   columns
>> Hmm, interesting.  Yay for more dead code removal.  Didn't verify it.
> I have committed these first three.  I'll leave it at that for now.

I have committed a few more patches from this series that were already
agreed upon. The remaining ones are rebased and reordered a bit, attached.

There was some doubt about the patch "Refactor ATExecAddColumn() to use
BuildDescForRelation()" (now 0009), whether it's too clever to build a
fake one-item tuple descriptor. I am working on another patch, which I
hope to post this week, that proposes to replace the use of tuple
descriptors there with a List of something. That would then allow maybe
rewriting this in a less-clever way. That patch incidentally also wants
to move BuildDescForRelation from tupdesc.c to tablecmds.c (patch 0007

Attachment Content-Type Size
v2-0001-Clean-up-MergeAttributesIntoExisting.patch text/plain 12.4 KB
v2-0002-Clean-up-MergeCheckConstraint.patch text/plain 3.9 KB
v2-0003-MergeAttributes-and-related-variable-renaming.patch text/plain 15.2 KB
v2-0004-Add-TupleDescGetDefault.patch text/plain 5.0 KB
v2-0005-Improve-some-catalog-documentation.patch text/plain 2.1 KB
v2-0006-Push-attidentity-and-attgenerated-handling-into-B.patch text/plain 1.6 KB
v2-0007-Move-BuildDescForRelation-from-tupdesc.c-to-table.patch text/plain 8.7 KB
v2-0008-Push-attcompression-and-attstorage-handling-into-.patch text/plain 1.8 KB
v2-0009-Refactor-ATExecAddColumn-to-use-BuildDescForRelat.patch text/plain 7.1 KB
v2-0010-MergeAttributes-convert-pg_attribute-back-to-Colu.patch text/plain 16.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2023-08-29 08:45:42 Re: postgres_fdw: wrong results with self join + enable_nestloop off
Previous Message Amit Kapila 2023-08-29 08:21:27 Re: logical_replication_mode