| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Cc: | Dmitriy Sarafannikov <dsarafannikov(at)yandex(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow GiST opcalsses without compress\decompres functions |
| Date: | 2017-09-15 12:36:03 |
| Message-ID: | 74578F4E-B686-41CF-BB43-912FCCFC8C1D@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dmitry and Alexander, thank you for looking into the patch!
> 14 сент. 2017 г., в 18:42, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> написал(а):
> It would be good if someone would write patch for removing useless compress/decompress methods from builtin and contrib GiST opclasses. Especially when it gives benefit in IndexOnlyScan enabling.
If the patch will be accepted, I'll either do this myself for commitfest at November or charge some students from Yandex Data School to do this (they earn some points in algorithms course for contributing to OSS).
> BTW, this change in the patch look suspicious for me
> ....
> We are typically evade changing formatting in fragments of codes not directly touched by the patch.
Thanks for spotting this out. Here's fixed version.
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Allow-uncompressed-GiST-4.patch | application/octet-stream | 7.4 KB |
| unknown_filename | text/plain | 1 byte |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-15 12:43:38 | Re: Log LDAP "diagnostic messages"? |
| Previous Message | Amit Langote | 2017-09-15 12:28:47 | Re: no test coverage for ALTER FOREIGN DATA WRAPPER name HANDLER ... |