| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: allow online change primary_conninfo |
| Date: | 2019-02-16 11:50:35 |
| Message-ID: | 7431841550317835@sas1-fb8a605c4548.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
> I don't quite think this is the right design. IMO the startup process
> should signal the walreceiver to shut down, and the wal receiver should
> never look at the config.
Ok, i can rewrite such way. Please check attached version.
> Otherwise there's chances for knowledge of
> pg.conf to differ between the processes.
I still not understood why this:
- is not issue for startup process with all primary_conninfo logic
- but issue for walreceiver with Michael Paquier patch; therefore without any primary_conninfo change logic in startup.
In both cases primary_conninfo change logic is only in one process.
regards, Sergei
| Attachment | Content-Type | Size |
|---|---|---|
| reload_walreceiver_conninfo_v005.patch | text/x-diff | 6.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2019-02-16 12:22:58 | Re: Online verification of checksums |
| Previous Message | Ramanarayana | 2019-02-16 11:49:08 | Re: libpq host/hostaddr/conninfo inconsistencies |