| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | robertmhaas(at)gmail(dot)com, amit(dot)kapila16(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, andres(at)anarazel(dot)de |
| Subject: | Re: Question about StartLogicalReplication() error path |
| Date: | 2021-06-16 22:55:46 |
| Message-ID: | 73690795b67b1e0f4ea005cf930e64d228eadf45.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2021-06-15 at 15:19 +0900, Kyotaro Horiguchi wrote:
> I don't think the message is neded, but I don't oppose it as far as
> the level is LOG and the messages were changed as something like
> this:
>
>
> - elog(DEBUG1, "cannot stream from %X/%X, minimum is
> %X/%X, forwarding",
> + elog(LOG, "%X/%X has been already streamed,
> forwarding to %X/%X",
>
> FWIW, I most prefer #1. I see #2 as optional. and see #3 as the
> above.
Attached.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| logical-start-doc-fix.diff | text/x-patch | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2021-06-16 22:59:11 | Re: Outdated replication protocol error? |
| Previous Message | Alvaro Herrera | 2021-06-16 22:28:28 | Re: Unresolved repliaction hang and stop problem. |