From: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Using base backup exclusion filters to reduce data transferred with pg_rewind |
Date: | 2018-03-13 10:16:27 |
Message-ID: | 725f0849-eb1a-5cca-e66f-69cec58576ef@postgrespro.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
05.02.2018 10:10, Michael Paquier:
> So the patch set attached is made of the following:
> - 0001, which refactors all hardcoded system paths into pg_paths.h.
> This modifies only initdb.c and basebackup.c to ease reviews.
> - 0002 spreads the path changes and the use of pg_paths.h across the
> core code.
> - 0003 moves the last set of definitions with backup_label,
> tablespace_map and pg_internal.init.
> - 0004 creates basebackup_paths.h, this can be consumed by pg_rewind.
> - 0005 makes the changes for pg_rewind.
Thank you for this set of patches.
This refactoring makes code way more convenient to read and change.
Due to some merge conflicts, patch 0002 was not applying clearly.
So I attach the updated version.
I also noticed a couple of rows that were not updated, and wrote a patch
0006,
which contains just minor changes and can be applied on top of any patch
after 0003.
Since these patches contain mostly cosmetic changes and do not break
anything,
I think it's fine to mark this thread as Ready For Committer without
long discussion.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment | Content-Type | Size |
---|---|---|
0001-Refactor-path-definitions-into-a-single-header-file-.patch | text/x-patch | 13.9 KB |
0002-v2-Replace-all-system-paths-hardcoded-with-data-from-pg.patch | text/x-patch | 57.3 KB |
0003-Add-backup_label-pg_internal.init-and-tablespace_map.patch | text/x-patch | 3.5 KB |
0004-Move-base-backup-filter-lists-into-their-own-header-.patch | text/x-patch | 7.1 KB |
0005-Use-filtering-list-of-base-backups-in-pg_rewind-to-e.patch | text/x-patch | 5.1 KB |
0006-Minor-renames.patch | text/x-patch | 1.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2018-03-13 10:31:39 | Re: Additional Statistics Hooks |
Previous Message | Aleksander Alekseev | 2018-03-13 09:55:43 | Re: Google Summer of Code: Potential Applicant |