effects of posix_fadvise on WAL logs

Hi all,

Does anyone have any tests that showcase benefits from the
posix_fadvise changes in xlog.c? I tried running some tests with dbt2
to see if any performance changes could be seen with 8.4beta2. I
thought an OLTP type test with a lot of inserts and updates would be a
good test. Unfortunately, I don't think I see anything interesting.
I was hoping to see less page cache activity, but maybe I'm not
looking correctly. Maybe there isn't enough activity to the WAL
relative to the rest of the database to show anything interesting?
Here are the tests I ran:

Baseline on 8.4beta2, using wal_sync_method=fsync:
http://207.173.203.223/~markwkm/community6/dbt2/m1500-8.4beta2/m1500.8.4beta2.2/report/

Next set wal_sync_method=open_sync for postix_fadvise:
http://207.173.203.223/~markwkm/community6/dbt2/m1500-8.4beta2/m1500.8.4beta2.osync1/report/

Now using the attached patch, with wal_sync_method=open_sync:
http://207.173.203.223/~markwkm/community6/dbt2/m1500-8.4beta2/m1500.8.4beta2.osync2/report/

I created the patch because currently posix_fadvise is used right
before the file handle to the WAL log is closed. I think
posix_fadvise needs to be called when the file is opened.

Regards,
Mark Wong