Re: Control your disk usage in PG: Introduction to Disk Quota Extension

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Haozhou Wang <hawang(at)pivotal(dot)io>
Cc: David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Hubert Zhang <hzhang(at)pivotal(dot)io>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)pivotal(dot)io>
Subject: Re: Control your disk usage in PG: Introduction to Disk Quota Extension
Date: 2020-07-01 08:36:43
Message-ID: 7025C3BF-C91E-44EB-AE45-121EC79DC1E4@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 27 Mar 2020, at 11:22, Haozhou Wang <hawang(at)pivotal(dot)io> wrote:

> We rebased this patch with the newest master.

This patch now fails to build according to Travis:

smgr.c: In function ‘smgrtruncate’:
smgr.c:578:47: error: passing argument 4 of ‘smgrtruncate_hook’ makes integer from pointer without a cast [-Werror=int-conversion]
(*smgrtruncate_hook)(reln, forknum, nforks, nblocks);
^
smgr.c:578:47: note: expected ‘BlockNumber {aka unsigned int}’ but argument is of type ‘BlockNumber * {aka unsigned int *}’

The warning is also present in the Windows build:

src/backend/storage/smgr/smgr.c(578): warning C4047: 'function' : 'BlockNumber' differs in levels of indirection from 'BlockNumber *' [C:\projects\postgresql\postgres.vcxproj]
src/backend/storage/smgr/smgr.c(578): warning C4024: 'smgrtruncate_hook' : different types for formal and actual parameter 4 [C:\projects\postgresql\postgres.vcxproj]
2 Warning(s)

Marking the patch as Waiting for Author.

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-07-01 08:41:01 Re: [Proposal] Add accumulated statistics for wait event
Previous Message Daniel Gustafsson 2020-07-01 08:15:34 Re: tar-related code in PostgreSQL