| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Taylor Vesely <tvesely(at)pivotal(dot)io>, Adam Lee <ali(at)pivotal(dot)io>, Melanie Plageman <mplageman(at)pivotal(dot)io>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Memory-Bounded Hash Aggregation |
| Date: | 2020-02-27 03:14:18 |
| Message-ID: | 6e7c269b9a84ff75fefcad8ab2d4758f03581e98.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2020-02-24 at 15:29 -0800, Andres Freund wrote:
> On 2020-02-22 11:02:16 -0800, Jeff Davis wrote:
> > On Sat, 2020-02-22 at 10:00 -0800, Andres Freund wrote:
> > > Both patches, or just 0013? Seems the earlier one might make the
> > > addition of the opcodes you add less verbose?
> >
> > Just 0013, thank you. 0008 looks like it will simplify things.
>
> Pushed 0008.
Rebased on your change. This simplified the JIT and interpretation code
quite a bit.
Also:
* caching the compiled expressions so I can switch between the variants
cheaply
* added "Planned Partitions" to explain output
* included tape buffers in the "Memory Used" output
* Simplified the way I try to track memory usage and trigger spilling.
* Reset hash tables always rather than rebuilding them from scratch.
I will do another round of performance tests and see if anything
changed from last time.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| hashagg-20200226.patch | text/x-patch | 99.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2020-02-27 03:48:30 | Crash by targetted recovery |
| Previous Message | Thomas Munro | 2020-02-27 03:10:14 | Re: Collation versioning |